Evaluate annotations before completing tree of definitions #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motive: That way we can identify annotation macros without special name resolution rules. This was surprisingly easy.
... relative to CollectionStrawman1.
| @@ -12,6 +12,8 @@ import annotation.tailrec | |||
| * strengths and weaknesses of different collection architectures. | |||
| * | |||
| * For a test file, see tests/run/CollectionTests.scala. | |||
| * | |||
| * Strawman4 is like strawman1, but built over views instead of by-name iterators | |||
There was a problem hiding this comment.
Yes, I just threw it in to save time.
|
I'll take a look on Mon/Tue 16/17 May after my arrival back to Europe. Looking forward to understanding better how Dotty works! |
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 8, 2016
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motive: That way we can identify annotation macros without special
name resolution rules.
This was surprisingly easy.
Review by @xeno-by